Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(pre-commit): replace pylint with ruff #5799

Merged
merged 2 commits into from
Jun 17, 2024
Merged

feature(pre-commit): replace pylint with ruff #5799

merged 2 commits into from
Jun 17, 2024

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Feb 9, 2023 •
edited
Loading

Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemented
and we can slow extend its configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE

@fruch fruch changed the title fix(pre-commit): limit to only on job feature(pre-commit): replace pylint with ruff Feb 12, 2023
soyacz
soyacz reviewed Feb 13, 2023
View reviewed changes
add_new_dc_test.py Outdated Show resolved Hide resolved
soyacz
soyacz reviewed Feb 13, 2023
View reviewed changes
cdc_replication_test.py Outdated Show resolved Hide resolved
@fruch fruch force-pushed the limit_pylint branch 3 times, most recently from 6462765 to 5080a41 Compare February 13, 2023 07:32
vponomaryov
vponomaryov reviewed Feb 13, 2023
View reviewed changes
add_new_dc_test.py Outdated Show resolved Hide resolved
@fruch fruch force-pushed the limit_pylint branch 3 times, most recently from c8afc34 to 93816e4 Compare February 14, 2023 14:23
@fruch fruch added test-provision-aws Run provision test on AWS test-provision-docker labels Dec 17, 2023
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Dec 17, 2023
@fruch
feature(pre-commit): replace pylint with ruff scylladb#5799
bd87079 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
@fruch fruch marked this pull request as ready for review December 17, 2023 22:32
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Dec 17, 2023
@fruch
feature(pre-commit): replace pylint with ruff scylladb#5799
bbebcf3 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Jan 25, 2024
@fruch
feature(pre-commit): replace pylint with ruff scylladb#5799
158d332 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
@fruch fruch requested a review from vponomaryov January 25, 2024 14:11
@fruch fruch added the backport/none Backport is not required label Jan 25, 2024
@fruch fruch requested review from roydahan and removed request for fgelcer January 25, 2024 14:12
@vponomaryov
Copy link
Contributor

If you are gonna read it all line by line, every signal change here. I'll just merge it now and that's it.

that's not the point of such a change, it's not to review the changes, themselves but the tool / rules we are using.

I don't see arguments against creating first PR with first commit and further keeping adequate number of changes per PR.
I see only threat to merge if I review code in the place where it is the main goal - to review code.

We already could merge first one or two commits with full confidence in the made changes.

@fruch
Copy link
Contributor Author

fruch commented Feb 8, 2024

If you are gonna read it all line by line, every signal change here. I'll just merge it now and that's it.
that's not the point of such a change, it's not to review the changes, themselves but the tool / rules we are using.

I don't see arguments against creating first PR with first commit and further keeping adequate number of changes per PR. I see only threat to merge if I review code in the place where it is the main goal - to review code.

We already could merge first one or two commits with full confidence in the made changes.

Separating those make no sense, and would me that we'll have almost no lint on master until the rest of those would be introduced.

or we have confidence in the tool we are introducing, or we don't, I don't see a point review every single automated change that the tool was doing (which 99% of those change are)

fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Jun 2, 2024
@fruch
feature(pre-commit): replace pylint with ruff scylladb#5799
1a721d6 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
@fruch fruch dismissed vponomaryov’s stale review June 4, 2024 19:22

left the minimal set of linting rules

fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Jun 16, 2024
@fruch
feature(pre-commit): replace pylint with ruff scylladb#5799
2c2fc7d 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
vponomaryov
vponomaryov previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vponomaryov
Copy link
Contributor

@fruch need to rebase it.

soyacz
soyacz previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's do it :)

fruch added 2 commits June 17, 2024 16:17
@fruch
feature(pre-commit): replace pylint with ruff scylladb#5799
d05b206 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
@fruch
feature(ruff): add blind except (BLE) checks
ecd3240 
Ref: https://github.com/charliermarsh/ruff#flake8-blind-except-ble
@fruch fruch dismissed stale reviews from soyacz and vponomaryov via ecd3240 June 17, 2024 13:18
@fruch fruch merged commit 418624b into scylladb:master Jun 17, 2024
2 of 3 checks passed
fruch added a commit that referenced this pull request Jun 17, 2024
@fruch
feature(pre-commit): replace pylint with ruff #5799
8bc05ae 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
dimakr pushed a commit to dimakr/scylla-cluster-tests that referenced this pull request Jun 18, 2024
@fruch @dimakr
feature(pre-commit): replace pylint with ruff scylladb#5799
e55ca39 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
This was referenced Jun 26, 2024
Merged
Closed
mikliapko pushed a commit to mikliapko/scylla-cluster-tests that referenced this pull request Jun 27, 2024
@fruch @mikliapko
feature(pre-commit): replace pylint with ruff scylladb#5799
5d5479c 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
mikliapko pushed a commit to mikliapko/scylla-cluster-tests that referenced this pull request Jun 27, 2024
@fruch @mikliapko
feature(pre-commit): replace pylint with ruff scylladb#5799
b4ba549 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
fruch added a commit that referenced this pull request Jun 27, 2024
@fruch
feature(pre-commit): replace pylint with ruff #5799
ff269d2 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
@fruch fruch added backport/6.0 and removed backport/none Backport is not required labels Jun 30, 2024
mergify bot pushed a commit that referenced this pull request Jun 30, 2024
@fruch @mergify
feature(pre-commit): replace pylint with ruff #5799
0fe5fde 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
(cherry picked from commit 8bc05ae)

# Conflicts:
#	requirements.txt
@mergify mergify bot mentioned this pull request Jun 30, 2024
Merged
fruch added a commit that referenced this pull request Jun 30, 2024
@fruch
feature(pre-commit): replace pylint with ruff #5799
6be8c7f 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
(cherry picked from commit 8bc05ae)
fruch added a commit that referenced this pull request Jun 30, 2024
@fruch
feature(pre-commit): replace pylint with ruff #5799
1d8da2b 
Ruff is rust base linter for python that work incredibly fast
since pylint speed is causing use issue on SCT CI
we should start using ruff,
for now it uses the pylint set of rules it has implemeted
and we can slow extand it's configuration to use more
of the available rules set it has

Ref: https://github.com/charliermarsh/ruff
Ref: https://www.youtube.com/watch?v=jeoL4qsSLbE
(cherry picked from commit 8bc05ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vponomaryov vponomaryov vponomaryov left review comments

@soyacz soyacz soyacz left review comments

@roydahan roydahan Awaiting requested review from roydahan

@juliayakovlev juliayakovlev Awaiting requested review from juliayakovlev

@k0machi k0machi Awaiting requested review from k0machi

Assignees

@fruch fruch

Labels
backport/6.0 promoted-to-master test-provision-aws Run provision test on AWS test-provision-docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fruch @vponomaryov @soyacz @scylladbbot